Croway opened a new pull request, #135:
URL: https://github.com/apache/camel-upgrade-recipes/pull/135

   The review comment that `camel422_1.FlagOpenAIFullResponseProperty*` adds 
next to every `CamelOpenAIResponse` usage was 367 characters on one line, the 
longest comment any recipe in this repository emits (the next one is 124). In 
the Java DSL it is rendered inside the call argument, so a migrated route reads 
like
   
   ```java
   .setBody(exchangeProperty(/* CAMEL-24539 (Camel 4.22.1): with 
storeFullResponse=true, embeddings/audio-transcription/audio-translation now 
use 
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
 instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which 
operation this refers to and update the property name manually if 
needed.*/"CamelOpenAIResponse"));
   ```
   
   This keeps the JIRA key, the condition and the new property names and drops 
the rest (218 characters):
   
   ```java
   .setBody(exchangeProperty(/* CAMEL-24539: with storeFullResponse=true, 
embeddings and audio operations now store the full response under 
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of 
CamelOpenAIResponse; review this usage.*/"CamelOpenAIResponse"));
   ```
   
   The XML and YAML recipes share the constant, so their comments shrink the 
same way. The `CAMEL-24539` marker used to detect an already-added comment is 
unchanged, so a project migrated with 4.22.0 of the recipes does not get a 
second comment.
   
   Spotted while running the 4.23 migration (#132) on a sample application. The 
4.23 test class on that branch quotes the old text and will be updated there 
once this is merged.
   
   **Tests**: `CamelUpdate422_1Test` 7/7 (the 17 expectations updated).
   
   _Claude Code on behalf of croway_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to