gnodet-bot commented on code in PR #28030: URL: https://github.com/apache/camel/pull/28030#discussion_r4306492094
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc: ########## @@ -743,6 +743,14 @@ now read as a local date-time without a zone (`getDate()` returns a `LocalDateTi definition of an earlier message, if there was one. A calendar that defines a `TZID` an earlier message has defined differently is now read with its own definition. +=== camel-flatpack - marshal writes the first row of the list + +With the default `ignoreFirstRecord=true`, marshalling a `List<Map<String, Object>>` skipped the first map, so the +first data row was missing from the output, for delimited and fixed-length files alike (the header line of a delimited +file is written from the column names, not from the first map). Every map of the list is now written, and +`ignoreFirstRecord` only applies to unmarshal. A route that set `ignoreFirstRecord=false` to work around this is not +affected; a route that added a dummy first map now gets it in the output too. Review Comment: 💡 **Nit:** The note tells users the dummy first map will appear in the output, but doesn't say what to do about it. Making the migration step explicit: ```suggestion `ignoreFirstRecord` only applies to unmarshal. A route that set `ignoreFirstRecord=false` to work around this is not affected; a route that added a dummy first map must remove it — the dummy entry will now appear as a real data row in the output. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
