allthingssecurity commented on PR #28029: URL: https://github.com/apache/camel/pull/28029#issuecomment-6248478982
Thanks for tracing the reifiers, and for pointing at the right place for this. I agree the hand-maintained lists were the weak part. Done your way in 64145639d0f7: - `ModelWriterGeneratorMojo.Property.getDefaultValue()` now returns `null` for the options where "not set" means "the value of a parent level", so the generated XML, YAML and Java writers keep them whenever they are set. These are every option declared on `RedeliveryPolicyDefinition`, `Resilience4jConfigurationCommon` and `FaultToleranceConfigurationCommon`; the six rest binding options declared on `RestConfigurationDefinition`, `RestDefinition`, `VerbDefinition` and `RestBindingDefinition`; and `shutdownRoute` / `shutdownRunningTask` of `RouteDefinition`. They are matched by declaring class and name, not by attribute name only, in one place with the reason next to it. - The `INHERITED_OPTIONS` lists and the `keepDefault` overrides are gone from the three dumpers; they are back to what main has. - The three writers are regenerated. Their diff is only those `doWriteAttribute(..., "<default>")` arguments turning into `null` (69 per writer). - New `JavaDumpExplicitDefaultValuesTest` in camel-java-io: it compiles the Java dump of a route, loads it and runs it (an onException with `redeliveryDelay(1000)` under an error handler with 30 s). It fails with the writer generated by main (`not redelivered within 10 seconds`). For that, camel-java-io gets `camel-core-languages` and `camel-direct` as test dependencies. Tests, run in one reactor with the plugin so the writers come from it: camel-package-maven-plugin 82, camel-xml-io 426 (2 skipped), camel-yaml-io 189, camel-java-io 189 (1 skipped), camel-xml-io-dsl 72, camel-yaml-dsl 486, all with 0 failures. On `skipBindingOnErrorCode`: agreed, that mismatch (model `false`, `RestConfiguration` `true`) belongs in its own JIRA. I will open it separately and link it here. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
