allthingssecurity commented on PR #28035: URL: https://github.com/apache/camel/pull/28035#issuecomment-6248479147
Thanks for the thorough review. All three points are addressed in e47aeb82b34e (details in the inline replies): - The gate is gone. While the done file is kept, the polls consume every file of the directory, so a Camel producer that rewrites the done file during the drain no longer strands its files (new test with `file:...?doneFileName=ready` as the producer). - pollEnrich / `ConsumerTemplate.receive`: there is a new test and an upgrade-guide line. The full listing is replaced by listing one file past the limit. - preMove: the done file kept is the one of the file as polled. On the description mismatch: with the gate removed, a last file that fails while files are left is tried again under the same done file, as on main. `testFileThatAlwaysFailsWithFilesLeftDoesNotHoldDoneFile` now pins that, since b.txt is tried twice before the done file is deleted. I have updated the PR description to match. Tests: 14 in `FileConsumerDoneFileNameFilesLeftTest`. Against the previous commit, 4 of them fail (the producer, the file written meanwhile, the preMove case, and the retry of the failed last file). camel-file: 24 tests. The camel-core file tests: 474 run, 12 skipped, 0 failures. camel-ftp: the 17 done-file, maxMessagesPerPoll, consumer-template and pollEnrich ITs (24 tests) plus `RemoteFileIgnoreDoPollErrorTest` and `SftpPreSortTest` (14) all pass. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
