davsclaus commented on code in PR #28033:
URL: https://github.com/apache/camel/pull/28033#discussion_r4306093385


##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -724,6 +724,13 @@ registered.
 To restore the previous behaviour, set `webhookSecretTokenEnabled=false`: the 
webhook is then registered without a
 secret token, and webhook requests are not verified.
 
+=== camel-iggy - messageExpiry is sent to Iggy in microseconds
+
+The `messageExpiry` option is in seconds, but its value was passed unchanged 
to Iggy, which reads the message expiry
+of a topic in microseconds, so a topic created by Camel 
(`autoCreateTopic=true`) expired its messages a million times
+too early (`messageExpiry=3600` gave 3.6 ms instead of one hour). The value is 
now converted to microseconds. Topics
+created before keep their expiry: change it on the Iggy server.

Review Comment:
   Users who worked around this by setting `messageExpiry` in microseconds are 
affected the other way now. Worth one more sentence:
   
   ```suggestion
   created before keep their expiry: change it on the Iggy server. If you set 
`messageExpiry` in microseconds to work
   around this, set it in seconds now, or newly created topics keep their 
messages a million times longer than intended.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to