gnodet-bot commented on code in PR #27433: URL: https://github.com/apache/camel/pull/27433#discussion_r4305961729
########## core/camel-core/src/test/java/org/apache/camel/support/jsse/SSLContextParametersTest.java: ########## @@ -36,6 +36,7 @@ import org.junit.jupiter.api.condition.JRE; import org.junit.jupiter.api.parallel.Isolated; +import static org.assertj.core.api.Assertions.assertThat; Review Comment: 🔧 **Assertion style mismatch:** the PR adds `import static org.assertj.core.api.Assertions.assertThat` and uses `assertThat(...).isEmpty()` in a method where the entire file uses JUnit assertions. Both @oscerd and @davsclaus flagged this. Either switch to JUnit: ```suggestion import static org.junit.jupiter.api.Assertions.*; ``` (and use `assertEquals(0, getSignatureSchemes(...).length)` for the three assertions), or follow @davsclaus's other suggestion to delete the empty-filter block entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
