gnodet-bot commented on code in PR #27827:
URL: https://github.com/apache/camel/pull/27827#discussion_r4296924124
##########
dsl/camel-jbang/camel-launcher/src/test/java/org/apache/camel/dsl/jbang/launcher/WebsiteInstallerFixture.java:
##########
@@ -64,6 +64,8 @@ final class WebsiteInstallerFixture implements AutoCloseable {
private static final String KEY_ALIAS = "camel-installer-test";
private static final String DEFAULT_BASE_VERSION = "9.9.9";
private static final Duration PROCESS_TIMEOUT = Duration.ofSeconds(60);
+ private static final Path POWERSHELL_MODULE_ANALYSIS_CACHE
+ = Path.of("target", "powershell",
"ModuleAnalysisCache").toAbsolutePath();
Review Comment:
💡 **Note:** `POWERSHELL_MODULE_ANALYSIS_CACHE` is resolved via
`toAbsolutePath()` at class-load time, so it depends on the JVM working
directory at that moment. This is fine in the test harness context where `cwd`
is the project root, but worth a brief Javadoc comment to clarify the intent
(e.g. *"resolved relative to the Maven project root"*) so future readers don't
have to trace the call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
