gnodet-bot commented on code in PR #27686:
URL: https://github.com/apache/camel/pull/27686#discussion_r4261392958
##########
components/camel-kamelet/src/main/java/org/apache/camel/component/kamelet/Kamelet.java:
##########
@@ -252,13 +546,15 @@ public static RouteDefinition
templateToRoute(RouteTemplateDefinition in, Map<St
int line = -1;
boolean sink = false;
Collection<ToDefinition> col = filterTypeInOutputs(def.getOutputs(),
ToDefinition.class);
+
Review Comment:
💬 **Cosmetic (re-raise):** Blank line added before `for (ToDefinition to :
col)` is not present on `main`. Flagged by davsclaus multiple times. Please
remove.
##########
components/camel-kamelet/src/main/java/org/apache/camel/component/kamelet/Kamelet.java:
##########
@@ -252,13 +546,15 @@ public static RouteDefinition
templateToRoute(RouteTemplateDefinition in, Map<St
int line = -1;
boolean sink = false;
Collection<ToDefinition> col = filterTypeInOutputs(def.getOutputs(),
ToDefinition.class);
+
for (ToDefinition to : col) {
- if (to.getEndpointUri().startsWith("kamelet:sink") ||
to.getEndpointUri().startsWith("kamelet://sink")) {
+ if (isKameletEndpoint(to.getEndpointUri(), SINK_ID)) {
to.setUri("kamelet://sink?" + PARAM_ROUTE_ID + "=" + rid);
sink = true;
}
line = to.getLineNumber();
}
+
Review Comment:
💬 **Cosmetic (re-raise):** Blank line added between the closing `}` of the
`for` loop and `if (!sink)` is not present on `main`. Flagged by davsclaus
multiple times. Please remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
