davsclaus commented on PR #27690: URL: https://github.com/apache/camel/pull/27690#issuecomment-6120879883
Decision on the convention question: Camel's HTTP components will send **one header line per value**, like every mainstream HTTP client (JDK `HttpClient`, Apache HttpClient, OkHttp, Netty, Vert.x, Spring `HttpHeaders`, curl). That's what camel-http-common (servlet/jetty), netty-http, undertow and platform-http-vertx already do. RFC 9110 ยง5.3 makes it equivalent to one comma-separated line for list-based headers, and it is the only form that is correct for `Set-Cookie`. So the direction of this PR is right. camel-http's `[a, b]` is the odd one out (it isn't valid HTTP, since a receiver sees the values `[a` and `b]`). It will be changed separately in [CAMEL-25563](https://issues.apache.org/jira/browse/CAMEL-25563), not in this PR. For this PR, please: - drop the "The HTTP producers are not uniform here: camel-http sends ..." sentence from the upgrade guide (and from the commit message); - move the upgrade-guide note to `camel-4x-upgrade-guide-4_24.adoc` (`camel-4.23.x` is already branched, so this is not in 4.23.0); - only split collections and object arrays (`instanceof Collection || instanceof Object[]`), not every `Iterable`; - if you can, put the gate plus per-value filter in one helper in camel-support `HttpUtil`, shared with #27689 (CAMEL-25563 can then reuse it). _Claude Code on behalf of Claus Ibsen_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
