davsclaus commented on code in PR #27679:
URL: https://github.com/apache/camel/pull/27679#discussion_r4246225328
##########
components/camel-hashicorp-vault/src/main/docs/hashicorp-vault-component.adoc:
##########
@@ -363,6 +363,10 @@ YAML::
Where route will be the name of the secret stored in the HashiCorp Vault
instance, in the 'secret' engine.
+NOTE: The engine is the part before the first `:`. When the property has no
engine, such as `{{hashicorp:route}}`
+or `{{hashicorp:database#username}}`, the secret is read from the 'secret'
engine. A default value always needs the
+engine, as in `{{hashicorp:secret:route:default}}`: in
`{{hashicorp:route:default}}` the engine would be `route`.
Review Comment:
Right, thanks: for `database#username:admin` only the part before `#` is
checked for the engine, so it reads `secret/data/database` and falls back to
`admin`. Applied your wording in 945a6c1889be.
_Claude Code on behalf of Claus Ibsen_
##########
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs/hashicorp-vault-component.adoc:
##########
@@ -363,6 +363,10 @@ YAML::
Where route will be the name of the secret stored in the HashiCorp Vault
instance, in the 'secret' engine.
+NOTE: The engine is the part before the first `:`. When the property has no
engine, such as `{{hashicorp:route}}`
+or `{{hashicorp:database#username}}`, the secret is read from the 'secret'
engine. A default value always needs the
+engine, as in `{{hashicorp:secret:route:default}}`: in
`{{hashicorp:route:default}}` the engine would be `route`.
Review Comment:
Applied in 945a6c1889be; the catalog copy is identical to the component doc
again.
_Claude Code on behalf of Claus Ibsen_
##########
components/camel-hashicorp-vault/src/main/java/org/apache/camel/component/hashicorp/vault/HashicorpVaultPropertiesFunction.java:
##########
@@ -62,7 +62,8 @@
* This implementation is to return the secret value associated with a key.
The properties related to this kind of
* Properties Function are all prefixed with <tt>hashicorp:</tt>. For example
asking for
* <tt>hashicorp:engine:token</tt>, will return the secret value associated to
the secret named token on Hashicorp Vault
- * instance on the engine 'engine'.
+ * instance on the engine 'engine'. When no engine is given, such as
<tt>hashicorp:token</tt>, the 'secret' engine is
+ * used.
*
* Another way of retrieving a secret value is using the following notation
<tt>hashicorp:engine:database/username</tt>:
Review Comment:
Good catch, fixed in 945a6c1889be: both javadoc examples now use `#` for the
field (`hashicorp:engine:database#username` and `...#username:admin`).
_Claude Code on behalf of Claus Ibsen_
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -1021,6 +1021,18 @@ short by that count, so it now fails the record `length`
check (unless `ignoreMi
read with shifted fields. A system that reads these records by counting UTF-16
chars must count code points (or
graphemes) instead.
+=== camel-hashicorp-vault - properties without engine use the `secret` engine
Review Comment:
Thanks, moved in 945a6c1889be to a new `camel-4x-upgrade-guide-4_24.adoc`
under `== Upgrading Camel 4.23 to 4.24`, with the index entry. Also added the
`{{hashicorp:mysecret@2}}` change (now version 2 of `mysecret` in the `secret`
engine; before, `@2` stayed part of the name). #27681 creates the same file, so
whichever is merged second keeps the header once and both sections.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
