allthingssecurity commented on PR #27693:
URL: https://github.com/apache/camel/pull/27693#issuecomment-6120110807
- Connection leak: fixed in 41196072ddb6 (inline reply).
- Stop while a reconnect is pending: fixed in 41196072ddb6 as suggested.
`doStop` calls `reconnectTask.cancel(true)`
before it closes the connection and shuts the pool down;
`BackgroundTask.cancel` counts the latch down, so the
`run()` that the driver thread waits in returns. An attempt that is
connecting while the consumer stops closes the
connection it got. Test `stopReleasesTheThreadThatWaitsForAReconnect`: the
data source fails every reconnect, a
thread calls `closed()`, the consumer is stopped after the first failed
attempt, and the thread must end (bounded
`join`, no sleep). On the previous commit the thread is still waiting
after 20 seconds.
- AssertJ: the test class now uses AssertJ only (`assertj-core` added as a
test dependency of the module).
- camel-pgevent: 4 tests, 0 failures. The integration tests need a
PostgreSQL container and were not run.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
