davsclaus commented on code in PR #27675: URL: https://github.com/apache/camel/pull/27675#discussion_r4240436572
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc: ########## @@ -2637,6 +2637,13 @@ resolves back inside the polled directory remains accepted. Two configurations c server that reports names navigating above the polled directory, and a `fileName` expression (used when `useList=false`) that navigates above it. Set `jailStartingDirectory=false` if such a path is intended. +=== camel-mina-sftp - the producer applies the charset and allowNullBody options + +The producer wrote a String body in the charset of the exchange (UTF-8 unless the exchange sets another one) and Review Comment: When `charset` is set, `GenericFileHelper.toInputStream` also decodes non-String bodies (`byte[]`, `InputStream`, files) with the exchange charset and re-encodes them to the configured charset, as camel-sftp does. Previously those bytes were written as-is. Maybe add a sentence like: *"When `charset` is set, non-String bodies are also re-encoded to that charset; do not set `charset` for binary payloads."* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
