davsclaus opened a new pull request, #27666:
URL: https://github.com/apache/camel/pull/27666
Five shapes from the local-model benchmark traces (r7 and earlier) where the
validator's answer did not help the model, or told it the wrong fix. Counted
over all runs: maximumRedeliveries on onException in 107 steps, the unquoted
placeholder parse error in 65, cron=... in 75, retryAttemptedLogLevel on
deadLetterChannel in 57, script: under a language in 63.
| model wrote | before | now |
|---|---|---|
| `period: {{welcome.period}}` | `Expected a field name (Scalar value in
YAML), got this instead: <...MappingStartEvent...>`, no line | `line 5:
{{welcome.period}} without quotes is read as a YAML map ...: write the line as
period: "{{welcome.period}}"` |
| `path: {sku}` | `path is a plain string: write path: "...", not a language
map` | `{sku} without quotes is a YAML map ...: quote it, path: "{sku}"` |
| `cron:cron?cron=0/10 * * * * ?` | `Did you mean: [cronService]`, and a
quick fix renaming `cron=` to `cronService=` | `no option is named after the
component: write cron:name?schedule=...` (no quick fix) |
| `onException: {maximumRedeliveries: 0}` | no hint | `maximumRedeliveries
is an option of the redelivery policy: write it under redeliveryPolicy:, as
redeliveryPolicy: {maximumRedeliveries: 0}` |
| `deadLetterChannel: {retryAttemptedLogLevel: WARN}` | `did you mean
'level'?`, and a quick fix renaming it to `level:` | same as above |
| `groovy: {script: "..."}`, `simple: {text: "..."}` | no hint | `the groovy
text goes in expression:, write groovy: {expression: "..."}` (any language) |
The option-named-after-the-component rule is general (any component), and so
is the language rule (any language key, when the node has no `expression:` and
the unknown key holds text).
Tests: `QuotingAndOptionPlacementHintTest` (validator),
`SourceValidatorEndpointTest.anOptionNamedAfterTheComponentSaysWhatTheEndpointTakes`
(camel-jbang-core, also checks there is no quick fix). Suites:
camel-yaml-dsl-validator 227, camel-jbang-core 1753, camel-jbang-mcp 435, all
pass.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
