allthingssecurity commented on code in PR #27639:
URL: https://github.com/apache/camel/pull/27639#discussion_r4236654068


##########
components/camel-lucene/src/main/java/org/apache/camel/component/lucene/LuceneSearcher.java:
##########
@@ -52,9 +55,15 @@ public void open(File indexDirectory, Analyzer analyzer) 
throws IOException {
         this.analyzer = analyzer;
     }
 
+    /**
+     * Closes the index reader. The analyzer is not closed: it belongs to the 
endpoint (or the registry) and is used by
+     * the next query.
+     */
     public void close() throws IOException {

Review Comment:
   Added in de8a097f10: a `=== camel-lucene` section in the 4.23 upgrade guide 
saying that `LuceneSearcher.close()` no longer closes the analyzer passed to 
`open()`. It still merges cleanly with #27638 and #27640.
   
   _Claude Code on behalf of allthingssecurity_



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to