allthingssecurity commented on PR #27636:
URL: https://github.com/apache/camel/pull/27636#issuecomment-6094517311
Addressed the review in e308221 (`ReactiveStreamsConsumer implements
ShutdownAware`, draining mode as suggested in the inline comment; docs, catalog
copy and the upgrade guide entry say that a graceful shutdown routes the queued
items before the other routes are stopped).
New `ConsumerGracefulShutdownTest`:
`from("reactive-streams:in").to("direct:sub")` + `from("direct:sub")` in that
order, 10 items taken from the stream (first one gated in `direct:sub`, the
other 9 queued in the consumer), `context.stop()`. On the previous head c92970f:
```
testContextStopRoutesTheQueuedItemsToTheDirectRoute expected: <[1, 2, 3, 4,
5, 6, 7, 8, 9, 10]> but was: <[1]>
testShutdownTimeoutAppliesToTheQueuedItems The queued items must be routed
during the graceful shutdown ==> expected: <true> but was: <false>
```
Both pass with the change (the second one blocks item 2 with a 2 s shutdown
timeout and checks that the strategy waits for the queued items until its
timeout). camel-reactive-streams (77 tests), camel-reactor (25) and
camel-rxjava (25) pass. Note: this branch predates CAMEL-25500, so
`stopAllRoutes` still stops the routes one by one here; once on top of it, it
goes through the same pending-exchanges wait as `context.stop()`.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
