luigidemasi commented on PR #27602: URL: https://github.com/apache/camel/pull/27602#issuecomment-6080100457
Addressed the additional points from [this review](https://github.com/apache/camel/pull/27602#pullrequestreview-5469287115) in 68714d30c1c4 and 0dcb5c2f1507: - **Both null-message paths:** the outer submit/wait catch and inner provider catch now fall back to the exception class. Separate regression tests reproduce both failures before the fix. - **Ctrl+L:** narrowed the guard to active Semantic input. Existing search/filter/editor screens retain log pinning. The global-dispatch regression covers log search, alongside the existing Semantic clear-input test. - **Console discovery:** already registered consoles avoid resolution; missing consoles are retried at most once every five seconds. This reduces polling scans and still detects late registrations. A permanent one-shot guard would break that supported case; the regression checks repeated misses, late registration, and the registered fast path. - **File-action logging:** restored the server-side warning and exception while retaining the failure response to the client. - **Console shutdown:** an explicitly stopped console rejects calls until restarted. The test checks that no provider invocation occurs after stop and normal operation resumes after start. Resolver-created consoles remain callable without an explicit initial start, as the existing resolver API allows. On the connector field, serialized dispatch prevents concurrent initializers but does not serialize dispatch with shutdown. WebSocket shutdown uses `shutdownNow()` without joining an executing action. A controlled first-use/shutdown interleaving reproduced an executor surviving connector stop, including with `volatile` alone. The fix uses one monitor for creation/submission/shutdown and a lifecycle check; transport stop stays outside that monitor to avoid blocking file dispatch. Both lifecycle regressions fail before the fix. The branch name is retained to keep the existing PR branch stable; the PR title, tracking and commits use CAMEL-25491. Validation: 2,168 tests across camel-semantic, camel-cli-connector and camel-jbang-plugin-tui, with zero failures/errors, one skipped and retries disabled. The six new tests and enhanced discovery regression were verified to fail before their fixes. The full 704-module root reactor build also passed with tests skipped (5m 48s), including formatting and regeneration; it left no unexpected changes. _OpenAI Codex on behalf of @luigidemasi, via /oss-address-review._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
