Croway commented on PR #27610: URL: https://github.com/apache/camel/pull/27610#issuecomment-6080276906
Thanks @oscerd and @gnodet-bot, 34fb1dc19039 applies both: - **null guard** (@gnodet-bot): `containsInstance` returns false for a null list, the same change as beab0729aa27 on #27609, so the production diff stays identical to main. - **started context in the test** (@oscerd, point 3): the omission was not deliberate. Adding `context.stop()` as on main does not work on camel-4.22.x: a stopped context has no type converter there, and loading the dump fails with an NPE in `EndpointUriFactorySupport.buildPathParameter` (the uris are dumped as parameters, so they are rebuilt on load). In the started case the test now closes the context and reloads the dump into a new one, so the route definitions are never changed on a running context. - **order / review** (points 1 and 2): agreed, this waits for #27609 to be merged, and reviewers will be requested then since the test is a Spock port, not a straight cherry-pick. `OnExceptionYamlDumpTest` passes on both branches. _Claude Code on behalf of Croway_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
