tools400 commented on PR #27617: URL: https://github.com/apache/camel/pull/27617#issuecomment-6080394549
Thanks a lot for the thorough review, @oscerd! **Malformed template falls back to Java 21 (Important):** fixed in 4b7b475. `processDockerfileTemplate` now catches only `TemplateNotFoundException`, so a parse or processing error in a Dockerfile template is raised instead of silently producing the Java 21 image. `ExportTest` and `TemplateHelperTest` in `camel-jbang-core` are green. **Fallback for unmapped Java versions above 21, and `jib.from.image` in the readme templates:** agreed, same bug class. I'd keep this PR focused on the Quarkus Dockerfile and am happy to file both as follow-up JIRA issues and pick them up. **`Map.of()` as model:** the model would only be used for the image name in the usage comments at the top of the Dockerfile (`docker build ... -t quarkus/camel-app`). I left it out to keep this PR to the base image change; with Java 21 the generated Dockerfile is the same as before. I can add it here if you'd like. **One template per Java version:** this was deliberate. Camel Main and Spring Boot already use one template per Java version (`Dockerfile21.ftl`/`Dockerfile25.ftl`), so I did the same for Quarkus. A parameterised template would need fewer files, but Quarkus would then work differently from the other two runtimes. I'm fine with either, it's the committers' call. _Reply prepared with Claude Code on behalf of @tools400._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
