Repository: camel Updated Branches: refs/heads/master 38b5d1df2 -> 7b9076400
CAMEL-10983: Fail early and show meaningful log for invalid endpoint URI in Blueprint Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/7b907640 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/7b907640 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/7b907640 Branch: refs/heads/master Commit: 7b90764008ef2031d5bb9e4558224ffa0c2a1603 Parents: 7017bee Author: Tadayoshi Sato <sato.tadayo...@gmail.com> Authored: Fri Mar 10 22:05:12 2017 +0900 Committer: Andrea Cosentino <anco...@gmail.com> Committed: Fri Mar 10 16:03:58 2017 +0100 ---------------------------------------------------------------------- .../handler/CamelNamespaceHandler.java | 37 ++++++++++++++------ 1 file changed, 26 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/7b907640/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java ---------------------------------------------------------------------- diff --git a/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java b/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java index fde7d7e..3ad1f04 100644 --- a/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java +++ b/components/camel-blueprint/src/main/java/org/apache/camel/blueprint/handler/CamelNamespaceHandler.java @@ -16,6 +16,7 @@ */ package org.apache.camel.blueprint.handler; +import java.io.UnsupportedEncodingException; import java.lang.reflect.Field; import java.lang.reflect.Method; import java.lang.reflect.Modifier; @@ -987,9 +988,9 @@ public class CamelNamespaceHandler implements NamespaceHandler { CamelContextFactoryBean ccfb = (CamelContextFactoryBean) blueprintContainer.getComponentInstance(".camelBlueprint.factory." + camelContextName); CamelContext camelContext = ccfb.getContext(); - Set<String> components = new HashSet<String>(); - Set<String> languages = new HashSet<String>(); - Set<String> dataformats = new HashSet<String>(); + Set<String> components = new HashSet<>(); + Set<String> languages = new HashSet<>(); + Set<String> dataformats = new HashSet<>(); // regular camel routes for (RouteDefinition rd : camelContext.getRouteDefinitions()) { @@ -1151,16 +1152,20 @@ public class CamelNamespaceHandler implements NamespaceHandler { private void findUriComponent(String uri, Set<String> components) { // if the uri is a placeholder then skip it - if (uri != null && uri.startsWith(PropertiesComponent.DEFAULT_PREFIX_TOKEN)) { + if (uri == null || uri.startsWith(PropertiesComponent.DEFAULT_PREFIX_TOKEN)) { return; } - if (uri != null) { - String splitURI[] = ObjectHelper.splitOnCharacter(uri, ":", 2); - if (splitURI[1] != null) { - String scheme = splitURI[0]; - components.add(scheme); - } + // validate uri here up-front so a meaningful error can be logged for blueprint + // it will also speed up tests in case of failure + if (!validateUri(uri)) { + return; + } + + String splitURI[] = ObjectHelper.splitOnCharacter(uri, ":", 2); + if (splitURI[1] != null) { + String scheme = splitURI[0]; + components.add(scheme); } } @@ -1186,11 +1191,21 @@ public class CamelNamespaceHandler implements NamespaceHandler { } } } catch (URISyntaxException e) { - // ignore + // ignore as uri should be already validated at findUriComponent method } } } + private static boolean validateUri(String uri) { + try { + // the same validation as done in DefaultCamelContext#normalizeEndpointUri(String) + URISupport.normalizeUri(uri); + } catch (URISyntaxException | UnsupportedEncodingException e) { + LOG.error("Endpoint URI '" + uri + "' is not valid due to: " + e.getMessage(), e); + return false; + } + return true; + } } }
