gnodet commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-6055869742
@apupier — davsclaus has now given a final approval (2026-10-08) after the complete review cycle. Your previous change requests have been addressed: 1. ✅ **MXBean indirection** — two-step reflection via `getHikariPoolMXBean()` + `softEvictConnections()` (addressed in early commits) 2. ✅ **Real HikariCP + Agroal integration tests** — `DataSourceHelperHikariIntegrationTest` and `DataSourceHelperAgroalIntegrationTest` test against real pools with physical connection identity checks 3. ✅ **End-to-end credential rotation test** — tracked as [CAMEL-25149](https://issues.apache.org/jira/browse/CAMEL-25149) 4. ✅ **Camel Quarkus native reflection ticket** — [camel-quarkus#9252](https://github.com/apache/camel-quarkus/issues/9252) Could you clear your changes-requested? The PR is otherwise ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
