christophd commented on PR #27440: URL: https://github.com/apache/camel/pull/27440#issuecomment-6038871019
Addressing the latest review feedback from @oscerd and @davsclaus — summary of what's in this push and what's deferred: **Addressed in this push:** - **Failed endpoint start refCount** (blocking): `doStop()` now guards `unregisterEndpoint()` with `client != null` — no decrement if `doStart()` didn't complete. Test added. - **Typed context values**: `toValue()` uses `Value(Long)` for Long, `Number.doubleValue()` for Float/BigDecimal/Short, recurses into nested Map (`MutableStructure`) and List. Tests added for `Long.MAX_VALUE`, Float, nested Map, and List. - **Domain binding lookup-first**: `doStart()` checks `hasDomainBinding()` before `resolveProvider()` — no unnecessary provider/gRPC channel creation for shared domains. `registerEndpoint()` and `acquireClient()` separated for clear responsibilities. - **API shutdown**: `doStop()` calls `api.shutdown()` to release providers from the isolated API's static registry, fixing bean provider re-registration. - **Stale result headers**: cleared before setting new values. - **Language error logging**: shared `evaluateDetails()` method with WARN logging on errors for both producer and language paths. - **Cleanup**: removed unused `resolvedProvider` field, simplified `ownedProvider` lifecycle. **Deferred to follow-up issues:** - **`evaluationType=variant`** renaming to `string` and adding integer/double/object types — design decision, better as a separate PR while the component is still Preview. - **Implicit `flags` bean / inherited `flagsResource`** validation conflicts — needs careful design for precedence rules. - **Remote flagd** TLS label (`security` vs `common`), `certPath` silently ignored unless `tls=true`, and protobuf compatibility testing — needs a container-based integration test. _Claude Code on behalf of christophd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
