apupier opened a new pull request, #27085:
URL: https://github.com/apache/camel/pull/27085
Commit a37f972c0f45 (CAMEL-25088: camel-health - Health checks: fix bugs
found in a deep review) added a try/catch inside
AbstractHealthCheck.doCall()
so that unchecked exceptions thrown by a health check implementation are now
caught at the Camel layer:
try {
doCall(builder, options);
} catch (Exception e) {
builder.down();
builder.error(e);
builder.message("Health check failed due to: " +
e.getMessage());
}
Before this change, an unchecked exception propagated out of
AbstractHealthCheck.call() and was caught by SmallRye Health's own exception
handling, which reported the check under the class name
CamelMicroProfileHealthCheck and stored the exception as a 'rootCause' data
entry.
After this change, the exception is handled inside AbstractHealthCheck before
control returns to CamelMicroProfileHealthCheck.call(). The result flows
through CamelMicroProfileHealthHelper.applyHealthDetail() just like a checked
exception, so the check is reported under its own ID ('exception-check') and
the error is stored under the standard 'error.message' key.
Update testHealthCheckUncheckedException to assert the new behaviour:
- expected name: 'exception-check' (was: CamelMicroProfileHealthCheck class
name)
- expected data key: 'error.message' (was: 'rootCause')
there was this regression:
```
org.opentest4j.AssertionFailedError: expected:
<org.apache.camel.microprofile.health.CamelMicroProfileHealthCheck> but
was: <exception-check>
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1199)
at
org.apache.camel.microprofile.health.CamelMicroProfileHealthTestHelper.assertHealthCheckOutput(CamelMicroProfileHealthTestHelper.java:77)
at
org.apache.camel.microprofile.health.CamelMicroProfileHealthTestSupport.assertHealthCheckOutput(CamelMicroProfileHealthTestSupport.java:97)
at
org.apache.camel.microprofile.health.CamelMicroProfileHealthCheckTest.testHealthCheckUncheckedException(CamelMicroProfileHealthCheckTest.java:291)
```
Co-authored-with: IBM Bob 2.1.0
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
