oscerd commented on PR #26974: URL: https://github.com/apache/camel/pull/26974#issuecomment-5888324225
Evidence for the previous commit, since "the allowlist denies it" is worth demonstrating rather than asserting. Reverting `isDecisionPointUnavailable` to its previous shape fails three tests, three for three: the interrupted call, the pre-flight `FgaInvalidParameterException`, and `SdkSerializationException`. So all three were live paths on which `failOpen` allowed an exchange OpenFGA had never answered for, not theoretical ones. The interrupt case is the reason I checked at all. CAMEL-25139 found that camel-opa had a dedicated `InterruptedException` catch whose comment claimed fail-closed, and the catch never fired, because that SDK wraps an interrupted call in `OPAException` — so an interrupted REST call really was let through. This SDK cannot do the same: it issues the call with `HttpClient.sendAsync`, which does not declare `InterruptedException`, and no class in openfga-sdk 0.10.1 references that exception anywhere. So an interrupt cannot arrive disguised as the `IOException` the allowlist admits, and the only interrupt path is `future.get` on the calling thread. There is now a test driving exactly that — a future that never completes with the interrupt flag already set — rather than a comment claiming it. 96 unit tests and 12 ITs pass. --- _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
