gnodet-bot commented on PR #27073: URL: https://github.com/apache/camel/pull/27073#issuecomment-5888011254
💡 **Pre-existing doc inconsistency in `OpaConfiguration.setEvaluationMode` Javadoc (line 175):** The Javadoc says "`serverUrl`, `bearerToken` and `failOpen` do not apply in wasm mode" — but `failOpen` *does* apply in wasm mode, for a pool that stays busy past `borrowTimeout`. This was already true before this PR (the adoc docs at the _Wasm_ section say "failOpen still applies"), and this PR correctly narrows it to pool timeouts only via `OpaWasmEvaluator.isDecisionPointUnavailable`. But the `evaluationMode` description still claims it does not apply. Since this PR already updates `failOpen` semantics and documentation everywhere else (the `failOpen` Javadoc, the adoc Failure handling section, the OpaEndpoint comment), this one line is the last holdout. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
