oscerd commented on PR #27050:
URL: https://github.com/apache/camel/pull/27050#issuecomment-5886487615
_Claude Code on behalf of @oscerd_
I traced the `Unknown parameters=[{hash=1}]` failure. It isn't caused by
#26803 (CAMEL-24973), and it is already fixed on `main`, so I think the revert
can be dropped:
- **#26803 (84f265e8d1b3) only changed how the leftover parameters are
_printed_.** In `DefaultComponent.validateParameters` the message went from
`param` to `URISupport.sanitizeParameters(param)`, so secret values are masked.
The `if (!param.isEmpty()) throw new ResolveEndpointFailedException(...)`
condition is untouched. With the revert, the grpc endpoints would still fail
the same way, and `{hash=1}` would just be printed through `Map.toString()`.
- **The behaviour change came from #27014 (cf526fbe7625, CAMEL-25108, merged
2026-09-28 20:44 UTC).** It moved `parameters.remove("hash")` inside `if
(properties != null && !properties.isEmpty())`. After that, a `hash` in the URI
itself was treated as a regular endpoint parameter (see
`testHashParameterIsKept` added there). That breaks the port-0 grpc tests from
c86cb381e918, which rely on `hash` to create distinct endpoints.
- **@davsclaus already restored the unconditional
`parameters.remove("hash")` in 36f06e1370b7** (CAMEL-25108 follow-up, pushed
2026-09-29 07:31 UTC). Its commit message names the camel-grpc tests, and
`BaseClassesEdgeCasesTest.testHashParameterIsRemoved` now covers it. This PR's
branch is based on 54836b991f5c, which already contains that commit. So a build
of this branch passes the grpc tests because of 36f06e1370b7, not because of
the revert.
Verified on current `main` (54836b991f5c, #26803 in place), all camel-grpc
tests:
`mvn verify -pl components/camel-grpc -am -DskipITs
-Dtest='Grpc*Test,RouteControlledStreamObserverTest'
-Dsurefire.failIfNoSpecifiedTests=false`
→ **48 tests in 16 classes, 0 failures, 0 errors, 0 skipped**. This includes
`GrpcConsumerAggregationTest` (6/6), which uses the
`consumerStrategy=AGGREGATION&hash=1` URI from the description.
About the `port/camel-4.22.x` / `port/camel-4.18.x` labels: #27014 was never
backported, and `DefaultComponent` on both branches still removes `hash`
unconditionally. The grpc failure can't happen there. Reverting the backports
(#26895, #26962) would only drop the URI sanitization hardening.
So I'd suggest closing this PR without reverting. If you still see the grpc
failure on a build that includes 36f06e1370b7, please share the run link and
I'll look into it right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
