davsclaus opened a new pull request, #26989: URL: https://github.com/apache/camel/pull/26989
Fixes [CAMEL-25088](https://issues.apache.org/jira/browse/CAMEL-25088): bugs found in a deep review of the health checks. ## Fixed 1. **Readiness depended on the exposure level.** With the `default` and `oneline` exposure levels, checks in the `UNKNOWN` state (such as a disabled check) were left out, so Camel reported ready, while `full` reported not ready for the same state. The non-UP results are now included, so readiness is the same at every level. 2. **`camel.health.enabled=false` did not disable the health check registry.** 3. **Removed routes leaked.** The routes and consumers health check repositories kept the check of every removed route. 4. **A throwing check failed the whole health check.** It is now reported as `DOWN` with the exception as the error. 5. **`RouteHealthCheck` threw `NullPointerException` for a removed route.** 6. **`register()` rejected checks whose id only resembled another one**, such as a custom check `foo` when a route `foo` exists. 7. **A suspended route reported the registry's initial state** (`UP` with `initialState=UP`). It is now `DOWN`, as for a stopped route. 8. **The exclude pattern did not allow spaces around the comma.** The upgrade guide covers 1, 2, 4 and 7. ## Not changed - The result strategy runs after the success/failure counters are updated. - `ScheduledPollConsumer.lastErrorDetails` is a plain `HashMap` that the health check thread reads. - The health dev console lists the context check twice. ## Tests - **New tests:** `HealthCheckEdgeCasesTest` (camel-core, 7 tests) and `MainHealthCheckDisabledTest` (camel-main). All of them fail without the fix. - **Full suites:** camel-api, camel-health and camel-main pass. The full camel-core suite passes except for the resequencer, file cluster and `SimpleOperatorTest` tests, which failed because the older jars in `~/.m2` do not include recent commits (CAMEL-25052/25053/25013). Those tests pass when run with `-am`. _Claude Code on behalf of Claus Ibsen_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
