davsclaus opened a new pull request, #26991: URL: https://github.com/apache/camel/pull/26991
Fixes [CAMEL-25090](https://issues.apache.org/jira/browse/CAMEL-25090): bugs found in a deep review of the event notifiers and the vault configuration. ## Fixed 1. An exception from `EventNotifier.isEnabled` is now caught and logged, the same as one from `notify`. Before, it broke routing: - a route or the `CamelContext` failed to start or stop; - sending failed; - with `StepStartedEvent` the exchange never completed. 2. `ExchangeSentEvent` is now emitted when some notifier wants the sent event, even if no notifier accepted the sending event. Before, a notifier with `ignoreExchangeSendingEvents=true`, or whose `isEnabled` only accepts the sent event, got no sent events. The sql-trace dev console is one such notifier. `EventHelper.notifyExchangeSending` now returns true in that case too, so every caller (`SendProcessor`, `EventNotifierProducer`, `MulticastProcessor`, `DefaultProducerCache`, `EventNotifierCallback`) times the send. When no notifier wants either event, the `StopWatch` is still skipped. 3. The `ExchangeRedeliveryEvent` is now filtered by `ignoreExchangeRedeliveryEvents`. Before, it was filtered by `ignoreExchangeFailedEvents`. 4. `camel.vault.*` with more than one vault kind (such as aws and hashicorp) now configures every vault. Before, only the first was applied and the others were silently lost. 5. With camel-main, `VaultConfiguration.getAwsVaultConfiguration()` and the other getters now return the vault configured with `camel.vault.*`. Before, they returned null. The setters also update the fluent `aws()` builders. 6. An event notifier added after `CamelContext` has started is now started, and it is stopped when removed. The upgrade guide has an entry for 2, 3 and 6. `ManagedCamelContextRestartTest` asserted the old behaviour of 6 (a notifier added after start was never started), so it is updated. ## Not changed - camel-event still turns on sending events for an `ExchangeSent` consumer. That is no longer needed, but it does no harm. ## Tests - New tests: `EventNotifierEdgeCasesTest` (camel-core, 5 tests) and `MainVaultMultipleTest` (camel-main, 2 tests). All fail without the fix. - Full suites pass: camel-core (7770), camel-management (495), camel-main (253), camel-console (222), camel-support, camel-base-engine. _Claude Code on behalf of Claus Ibsen_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
