davsclaus commented on code in PR #26924:
URL: https://github.com/apache/camel/pull/26924#discussion_r4119214401
##########
core/camel-support/src/main/java/org/apache/camel/support/builder/ExpressionBuilder.java:
##########
@@ -175,6 +175,11 @@ public String toString() {
};
}
+ private static String typeName(Class<?> type) {
+ // the class resolver loads an array type by its canonical name
(byte[]) and not by its binary name ([B)
+ return type.isArray() ? type.getCanonicalName() : type.getName();
Review Comment:
Agreed, thanks. In 14ee61cc5aa1 the `Class` overloads of `headerExpression`
and `variableExpression` now use the given type directly instead of resolving
its name again, so `int[]`, `byte[][]` and arrays of nested classes work too. I
extended `testHeaderAndVariableAsArrayType` to cover them.
_Claude Code on behalf of davsclaus_
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -173,6 +173,15 @@ Only options whose value is a placeholder are affected,
and only when running wi
Camel Quarkus. If a component must not be stopped on reload, configure it
programmatically rather than with a
placeholder based property.
+=== Languages - less than with two null values, and a source from a variable
+
+- The `<` operator (in the Simple language and the Java DSL `isLessThan`) is
now `false` when both sides are `null`,
+ as the `>` operator already was. Prior to Camel 4.23, `${header.a} <
${header.b}` was `true` when neither header
+ existed. The `<=` and `>=` operators are unchanged and are `true` in that
case.
+- A language that reads its input from a `source` of `variable:name` now fails
with `NoSuchVariableException` when the
Review Comment:
Added in 14ee61cc5aa1: the note now covers a plain `source="myVar"` and the
`source` option of the xslt, xslt-saxon and xquery endpoints.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
