oscerd commented on PR #26888: URL: https://github.com/apache/camel/pull/26888#issuecomment-5830073243
CI failure here is the junit5/junit6 divergence, not a problem with the change itself. `build (21, false)` fails with: ``` PulsarConsumerReceiveErrorTest.java:[29,36] package org.apache.camel.test.junit6 does not exist PulsarConsumerReceiveErrorTest.java:[50,53] cannot find symbol: class CamelTestSupport ``` `components/camel-pulsar/pom.xml` depends on `camel-test-junit6` on `main` and on `camel-4.22.x`, but still on **`camel-test-junit5`** on `camel-4.18.x` — the module has not been migrated on that branch. The other test classes there already import `org.apache.camel.test.junit5.CamelTestSupport`. One-line fix on this branch: ```diff -import org.apache.camel.test.junit6.CamelTestSupport; +import org.apache.camel.test.junit5.CamelTestSupport; ``` in `components/camel-pulsar/src/test/java/org/apache/camel/component/pulsar/PulsarConsumerReceiveErrorTest.java`. Nothing else in the new test needs adapting — it uses Mockito and plain JUnit assertions, both of which are the same on that branch. I have not pushed it myself: this branch is on @gnodet's fork and I did not create it. Happy to if you would rather I did, or you can take the one-liner. Note that it makes this port no longer byte-identical to #26778, so by the project's own rule it wants a look rather than an as-is merge — though the delta is only the import. The `camel-4.22.x` port (#26887) is unaffected; that branch is already on junit6. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
