Croway commented on PR #26845: URL: https://github.com/apache/camel/pull/26845#issuecomment-5816393374
CAMEL-24638 asks us to refresh the credentials used by the pool and evict old connections. Where does this patch update the existing DataSource with the rotated credential? softEvictConnections() alone can create replacement connections with the original password. Does this also need to support Agroal? DataSourceHelper only recognizes Hikari’s MXBean. An Agroal pool reaches the logging fallback without a flush. Agroal provides flush(FlushMode.GRACEFUL), while its default configuration does not guarantee replacement through borrow validation or maximum lifetime. Please cover the intended pool types with a test that rotates the credential and verifies a subsequent connection authenticates with it. _AI-generated by Codex on behalf of @Croway._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
