ullgren commented on PR #26203:
URL: https://github.com/apache/camel/pull/26203#issuecomment-5816624951
@davsclaus regarding your "worth a look (non-blocking)" list:
> * With two APIs in camel mode and nested base paths (/api and /api/v3),
every catch-all is .last(), so whichever starts first answers unmatched
requests for both. For example, PUT /api/v3/pet/123 can get a 404 from the /api
processor instead of a 405 from /api/v3.
testCatchAllDoesNotShadowApiWithNestedBasePath can't catch this, because both
processors share the handler.
>
Added documentation for this limitation.
> * Spring Boot: was the catch-all via phc.addHttpEndpoint tested against
camel-spring-boot? And with base path /, does the root catch-all
(/{*matchOnUriPrefix}) take over static resources or other MVC mappings?
>
Tested this in a stand alone application. You are correct the catch-all, as
implemented now, takes over static resources and other MVC mappings. Actuators
survive since they are registered on a lower order.
I will look into if there is something we can do for this or if there is a
workaround we can add to the documentation,
> * Vert.x with serverRequestValidation=true: when content types don't
match, Vert.x keeps looking at later routes, so the camel catch-all may accept
requests that should get a 415/406. Is that intended?
>
No it is not. I will look into this.
> * From my earlier review, still open: should
RestOpenApiUnmatchedRequestHandler move to camel-api so camel-rest-postman can
reuse it? Fine to leave it component-local if you prefer, but a reply would
help.
>
Sorry missed this comment. Will move RestOpenApiUnmatchedRequestHandler to
camel-api
> * The JIRA description should be updated for the new
unmatchedRequestHandling option. Several commit messages lack the CAMEL-24649:
prefix, but a squash merge fixes that.
>
Will update the JIRA description. And yes will fix the commit message by
doing a squash before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
