Croway commented on code in PR #26856:
URL: https://github.com/apache/camel/pull/26856#discussion_r4093970795
##########
components/camel-ai/camel-ai-tool/src/main/java/org/apache/camel/component/ai/tool/AiToolEndpoint.java:
##########
@@ -51,6 +51,8 @@ public class AiToolEndpoint extends DefaultEndpoint {
@UriParam(description = "Tool configuration including tags, description,
and parameter definitions.")
private AiToolConfiguration configuration;
Review Comment:
Applied in 827919c0ad32 as zero-cost hardening.
For the record, the accesses are already ordered: `createConsumer()` and the
endpoint `doStart()` run back to back on the same thread
(`InternalRouteStartupManager` calls `routeService.setUp()` then
`routeService.warmUp()`), and `BaseService.start()`/`stop()` take the same
per-service lock, so a `doStop()` from another thread (shutdown hook, JMX)
acquires the lock released after the write. Route reload and dynamic route
addition go through the same `safelyStartRouteServices` path.
_Claude Code on behalf of Croway_
##########
components/camel-ai/camel-ai-resource/src/main/java/org/apache/camel/component/ai/resource/AiResourceEndpoint.java:
##########
@@ -51,6 +51,8 @@ public class AiResourceEndpoint extends DefaultEndpoint {
@UriParam(description = "Resource configuration including the resource
uri, tags, description and MIME type.")
private AiResourceConfiguration configuration;
Review Comment:
Applied in 827919c0ad32, same reasoning as on `AiToolEndpoint`.
_Claude Code on behalf of Croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
