gnodet-bot commented on code in PR #26838: URL: https://github.com/apache/camel/pull/26838#discussion_r4092664148
########## docs/main/modules/contributing/pages/building.adoc: ########## @@ -166,32 +166,24 @@ mvn clean install -Psourcecheck The opt-in `-Pdep-check` profile leverages https://github.com/maveniverse/pilot[`pilot:dependencies`] for bytecode-level detection of *used-but-undeclared* and *unused-but-declared* dependencies. It is non-blocking by default (report mode), so it only prints findings without failing the build. -The mojo requires compiled classes. -Run `compile` first (test-scope analysis is skipped by default, since many modules depend on -`camel-test-spring-junit6` which is not resolvable in a clean checkout without a prior install): +The mojo requires compiled classes and packaged JARs for all reactor modules. +Run `package -DskipTests` first: [source,bash] ---- -# Full reactor — report mode (default, compile-scope only) -mvn compile eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check -Dpilot.skipTestScope=true -Dlicense.skip -Dquickly +# Full reactor — report mode (default, includes test-scope) +./mvnw package -DskipTests -Dlicense.skip eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check -# Single module — includes test-scope (camel-test-spring-junit6 is available after a local install) -mvn test-compile eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check ----- - -Or on a single module: - -[source,bash] ----- +# Single module (after a full reactor package) cd components/camel-ftp -mvn compile eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check -Dpilot.skipTestScope=true +mvn eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check Review Comment: 🔧 **Nit:** The single-module example uses bare `mvn` while all other examples in this block use `./mvnw`. Inconsistent — a user with an older system Maven could get confusing failures. ```suggestion ./mvnw eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies -Pdep-check ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
