gnodet-bot commented on code in PR #26792:
URL: https://github.com/apache/camel/pull/26792#discussion_r4092440037
##########
tooling/maven/bom-generator-maven-plugin/pom.xml:
##########
@@ -87,6 +87,15 @@
</dependency>
<!-- logging -->
+ <dependency>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
⚠️ **Non-logging deps placed after `<!-- logging -->` — misleading
structure.**
`javax.inject` and `maven-model` (lines 90–98) are not logging dependencies,
but they appear immediately after the `<!-- logging -->` comment and before
`log4j-slf4j2-impl`. A reader scanning this POM will assume everything after
that comment is logging infrastructure and may incorrectly remove or
scope-restrict these deps in a future refactor.
Move these two blocks to before the `<!-- logging -->` comment (i.e., after
the previous dependency block at line 87).
##########
tooling/maven/camel-package-maven-plugin/pom.xml:
##########
@@ -160,6 +164,23 @@
</dependency>
<!-- logging -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
⚠️ **Non-logging deps placed after `<!-- logging -->` — misleading
structure.**
`maven-resolver-api`, `asm`, `javax.inject`, and `maven-model` (lines
167–183) are not logging dependencies, but they appear immediately after the
`<!-- logging -->` comment. Same issue as `bom-generator-maven-plugin`: these
will be mistaken for logging infrastructure by future readers.
Move these four blocks to before the `<!-- logging -->` comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
