oscerd commented on PR #26734:
URL: https://github.com/apache/camel/pull/26734#issuecomment-5808353201
Reworded in `09406232` — you are right that the comment pointed at an
annotation this class does not have.
It now reads:
```java
// the loop guard is set before the thread that reads it. Nothing depends on
that order today: this class
// uses the default PER_METHOD lifecycle, so every test gets a fresh
instance with the field already false.
// It would matter under PER_CLASS, where @AfterEach leaves it true for the
next test
```
That also matches what I measured before pushing the reorder: with the
lifecycle forced to `PER_CLASS` and the method order fixed so the one test
asserting on the accept latch runs fourth rather than first, all five still
passed — `Thread.start()` takes far longer than the volatile store that
followed it. So the reorder is a habit worth keeping, not a fix for anything
observable, and the comment now says so rather than implying otherwise.
Comment only, no behaviour change. 22 tests green (17 `ResourceHelperTest` +
5 new).
---
One note for whoever picks this up: the only red check, **Dependency
Analysis (non-blocking)**, is not from this branch. It fails the same way on
every current PR I sampled (#26779, #26781, #26782):
```
Failed to parse plugin descriptor for
org.apache.camel:camel-yaml-dsl-validator-maven-plugin:4.23.0-SNAPSHOT
No plugin descriptor found at META-INF/maven/plugin.xml
```
Both `build (17)` and `build (25)` are green.
_Claude Code on behalf of @oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
