davsclaus commented on PR #26800: URL: https://github.com/apache/camel/pull/26800#issuecomment-5798814268
Addressed in 86053c62fc4c — all six were correct, and two were more than nits: - **`RouteGraph` was dead** — right, and it was the wrong half to delete. `RouteGraph` is the deliberate abstraction (the same topology `DefaultRouteTopologyDumper` builds at runtime), so `BodyTypeFlow` now calls it instead of keeping private copies of `routes()`, `endpointOf()`, `sendsTo()`, `normalize()`, `scheme()` and its own `Route` record. That removed 106 lines and the drift you predicted. - **`VERBS_WITH_BODY` / `BODY_FROM_OUTSIDE` unused** — confirmed, each appeared exactly once (its own declaration). Removed. The behaviour they suggested does come from the `VERBS_WITHOUT_BODY` allowlist and the fallthrough in `certainlyWithoutABody`, so they were also misleading about how the check works. - **`java.util.Set` with `Set` already imported** — fixed, including two further occurrences at lines 555 and 578 that weren't flagged, plus `java.util.HashSet`. - **Javadoc `@param known`** — applied. Verified green: 151 tests in camel-yaml-dsl-validator (`BodyTypeFlowTest` 8/8) and `OpenApiBodyFlowTest` 4/4 in camel-jbang-core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
