apupier commented on PR #26088:
URL: https://github.com/apache/camel/pull/26088#issuecomment-5760270974
> One observation while checking this, not caused by the PR but worth a
follow-up: on a current fork PR to `main` (#26628, run 35526400154, `build
(25)`), the existing step takes ~7 minutes (4:48 for the first `--deepen=50`
alone), goes through 50 → 200 → 1000 → full history, never finds a merge base,
and Scalpel silently does not run. So for fork PRs - most contributor PRs -
this step is currently pure cost. This change makes that path much cheaper but
does not fix it; my guess is that the PR head commits (`refs/pull/N/head`) are
never fetched, so `merge-base` on the merge commit cannot resolve. Fetching
`refs/pull/${{ github.event.pull_request.number }}/head` at the same depth next
to the base fetch would likely make Scalpel work for fork PRs too.
effectively something to look more closely.
Sounds when it is both on a fork and not upt to date with main branch
because the next build of it also on same fork found it in 50 iteration
https://github.com/apache/camel/actions/runs/35579824514/job/106270040485#step:3:23
reported https://issues.apache.org/jira/browse/CAMEL-24876 to handle it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
