gnodet-bot commented on code in PR #26494:
URL: https://github.com/apache/camel/pull/26494#discussion_r4023908456
##########
core/camel-core-catalog/src/main/java/org/apache/camel/catalog/impl/AbstractCamelCatalog.java:
##########
@@ -305,7 +305,7 @@ private EndpointValidationResult validateProperties(
boolean lookup = value.startsWith("#") && value.length() > 1;
// we cannot evaluate multi values as strict as the others, as
we don't know their expected types
boolean multiValue = prefix != null &&
originalName.startsWith(prefix)
- && row.isMultiValue();
+ && row.isMultiValue() || isMapEntry(row, originalName);
Review Comment:
**[low]** The precedence is correct (`&&` before `||`), but mixing them
without parentheses makes the intent harder to read at a glance. Consider
wrapping the `&&` chain to make the OR-of-two-conditions structure explicit:
```suggestion
boolean multiValue = (prefix != null &&
originalName.startsWith(prefix)
&& row.isMultiValue()) || isMapEntry(row,
originalName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
