davsclaus commented on PR #26103: URL: https://github.com/apache/camel/pull/26103#issuecomment-5551817527
To clarify the model requirement from the previous review: The new feature types (`DateTimeFeature`, `EnumFeature`, `JsonNodeFeature`) need their own dedicated `@Metadata`-annotated properties in the data format model (e.g. `enableDateTimeFeatures`, `enableEnumFeatures`, `enableJsonNodeFeatures` as String fields in `AbstractJacksonDataFormat` following the same pattern as `enableFeatures`/`disableFeatures`). Since these are Jackson 3 specific (these DatatypeFeature subtypes don't exist in Jackson 2 or other JSON libraries), any shared model that also covers other JSON data formats would need `excludeProperties` entries to suppress these new options there. The `doEnableFeatures()`/`doDisableFeatures()` extension is the right runtime wiring — it just needs to be driven from model properties, not only from the Java convenience methods. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
