atiaomar1978-hub commented on PR #26106: URL: https://github.com/apache/camel/pull/26106#issuecomment-5547150096
_This comment was generated by an AI agent on behalf of @atiaomar1978-hub._ Review feedback from @gnodet has been addressed and the branch rebased onto latest `main`: 1. **Long token counts** — Removed `Math.toIntExact` / `toTokenCount` from `OpenAIEmbeddingsProducer` and `OpenAIResponsesProducer`; token counts are passed directly as `long` values (CAMEL-24560 is already on `main`). 2. **`OpenAIResponsesProducer` deduplication** — Extracted shared `observedCall(exchange, model, ThrowingSupplier)` helper used by both `createResponse` and `createStructuredResponse`. 3. **Moderation security comments** — Restored the comments explaining why a mismatched moderation result count must fail the exchange (content-gating invariant) and why the full response is stored only after validation. Rebased commits on `main`: - `c6764d78` — initial observability instrumentation - `bcdb8f7f` — first review round (span scope, tests, docs) - `d1a3fc28` — gnodet review fixes Tests run locally after rebase: `GenAiUsageTest`, `OpenAIEmbeddingsObservabilityTest`, `OpenAIModerationObservabilityTest`, `OpenAIResponsesObservabilityTest` — all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
