gnodet commented on PR #26120: URL: https://github.com/apache/camel/pull/26120#issuecomment-5539538550
Addressed all review comments: - **Unrelated CI/Sonar/Scalpel changes**: The PR was rebased onto `upstream/main` — the diff now contains only the 2 test files. The earlier review was on a stale base that included fork-local CI changes. - **Use timed `assertIsSatisfied`**: Replaced `setResultWaitTime(30000)` + `result.assertIsSatisfied()` with `MockEndpoint.assertIsSatisfied(context, 30, TimeUnit.SECONDS)` — clearer and keeps the timeout at the assertion site. - **Add explanatory XML comment**: Added a comment above the endpoint explaining why `delete=true` is needed (state contamination from `FtpServiceExtension` never resetting the FTP directory). - **`readLock=changed`**: Not needed here — the producer writes via `template.sendBodyAndHeader()` which completes synchronously before the consumer polls. The consumer's `initialDelay=0` + `delay=10000` means the first poll happens after context start, by which point all 5 files are fully written. No partial-read risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
