Croway commented on PR #26039:
URL: https://github.com/apache/camel/pull/26039#issuecomment-5523177900
Two more things on top of @davsclaus' review, both in `LauncherHelperTest`:
**1. `parsesNestedJarUrlOnWindows` will fail on Linux/macOS CI even after
the `/!` fix.** `Paths.get(URI)` only strips the leading slash on Windows; on a
Unix host `file:/C:/Users/...` resolves to
`/C:/Users/user/camel-launcher-4.23.0.jar`, so `doesNotStartWith("/C:")` fails
(verified on macOS). Guard the strict assertion with `@EnabledOnOs(OS.WINDOWS)`
and keep a platform-neutral check (e.g.
`endsWith("camel-launcher-4.23.0.jar")`) for the other OSes.
**2. The Javadoc on `parseJarPath` and the inline comment in the
`jar:nested:` branch still show the wrong form**
(`jar:nested:/outer.jar!/...`); the suggestion commits only fix the test
strings. Should be `jar:nested:/outer.jar/!BOOT-INF/lib/inner.jar!/`.
Minor: `Path.of` and `Paths.get` are mixed in the same class; pick one.
_Claude Code on behalf of Croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
