oscerd commented on PR #9069:
URL: https://github.com/apache/camel-quarkus/pull/9069#issuecomment-5494533392
@jamesnetherton your assumption is correct, and it is worse than a docs gap
— this PR would break that workflow. Closing it.
`Run.java` in camel-jbang builds the goal like this, in both `runQuarkus()`
and `runExistingQuarkusProject()`:
```java
cmd.add("quarkus:" + (dev ? "dev" : "run"));
```
and the flag behind it is
```java
@Option(names = { "--reload", "--dev" },
description = "Enables dev mode (live reload when source files are
updated and saved)")
boolean dev;
```
which defaults to `false`. So a plain `camel run --runtime=quarkus` goes
through `quarkus:run`, i.e. **prod mode**, and the gate this PR adds would
switch the CLI connector off there. `camel ps`, `camel trace`, `camel top` and
friends would stop seeing those applications. Only `--dev` / `--reload` takes
the `quarkus:dev` path that still works.
That is a poor trade. The finding behind this was an insecure default, but
the connector's action-file IPC is local-only and same-user: anyone who can use
it already has filesystem access as the same user, so it is not a meaningful
boundary. Breaking the primary jbang workflow to close it costs more than it
buys, and a documentation note would not help — the failure is silent, with
nothing pointing at `exposure-mode`.
Closing this PR and #9052. If it is worth revisiting, the right order is the
other way round: have camel-jbang pass `-Dquarkus.camel.cli.exposure-mode=all`
when it launches a Quarkus app, and only then change the default here. That
needs an `apache/camel` change first, so I have not opened anything for it —
happy to if you think it is worth pursuing.
Thanks for catching it; I had not considered the jbang path at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
