oscerd commented on PR #735:
URL: https://github.com/apache/camel-karaf/pull/735#issuecomment-5411125135
Thanks for the review — and agreed on the C1 point.
`String.format("%02X", (int) ch)` yields `%80`–`%9F` for U+0080–U+009F,
where a strict percent-encoding would give the UTF-8 byte sequence
`%C2%80`–`%C2%9F`.
Leaving it as it is, for the reason you gave: the output is a display string
handed to `ShellTable`, not a URI that anything re-parses, and `%80` achieves
the security goal — the terminal never sees a raw C1 byte. Making it exact
would mean encoding the char's UTF-8 bytes, which is more code in service of a
string nothing consumes programmatically. Noted here in case this helper ever
grows a round-trip caller, in which case the encoding would need to become a
real one.
No code change, so the approval stands as given.
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
