atiaomar1978-hub commented on PR #25531:
URL: https://github.com/apache/camel/pull/25531#issuecomment-5398943721
## Review feedback addressed
_AI-generated on behalf of atiaomar1978-hub_
Thanks @davsclaus for the review. Both blocking items are addressed in
commit `13f774f`:
### 1. Unrelated `model.properties` change removed
Reverted
`core/camel-core-model/src/generated/resources/META-INF/services/org/apache/camel/model.properties`
to match `main` (same class of spurious generated drift called out in
`ba216589e5ee`).
### 2. Scenario A recovery-path test coverage
Added
`shouldRecoverReplyDestinationAfterRefreshWithRunningListenerContainer` to
`TemporaryQueueReplyManagerRefreshTest`:
- Creates a real `JmsEndpoint` with Artemis and starts the reply manager (so
`listenerContainer` is a running `DefaultJmsMessageListenerContainer`)
- Waits for the initial `replyTo` destination
- Calls `scheduleRefresh()` to arm recovery while consumers remain cached
- Asserts deferred recovery completes (`isRefreshPending()` clears, new
`replyTo` published, container still running)
This exercises `triggerReplyDestinationRecovery()` →
`runReplyDestinationRecovery()` →
`DefaultJmsMessageListenerContainer.recoverReplyDestinationAfterRefresh()`.
### Tests run locally
```
./mvnw -pl components/camel-jms -am test \
-Dtest=TemporaryQueueReplyManagerRefreshTest,JmsTemporaryReplyToRequestReplyIT
```
**Result:** 6 tests, 0 failures (5 unit + 1 IT).
### Non-blocking blast-radius question
Reusing Spring's `recoverAfterListenerSetupFailure()` is scoped to the
reply-manager DMLC instance only (not the main route consumer). With
`replyToConcurrentConsumers > 1` or a shared connection factory, recovery
recreates consumers on that container; it does not stop/start the producer-side
connection or other endpoints. Happy to add a note in the PR description or
JIRA if you'd like that documented explicitly.
Ready for another look when CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
