gnodet commented on PR #24855: URL: https://github.com/apache/camel/pull/24855#issuecomment-5023411678
All 8 review comments have been addressed in commit 3559638635b0: 1. **FileInvalidStartingPathTest** — now asserts the endpoint directory is configured and the fileName expression matches the configured value 2. **FileProduceTempPrefixTest** — switched to `Path` API (`Files.list()`, `Files.readString()`), uses proper imports instead of FQCNs, asserts exactly 1 file is created, verifies file content 3. **CustomSchemaFactoryFeatureTest** — added `assertSame` to verify the endpoint uses the same `SchemaFactory` instance that was registered in the registry 4. **CamelContextDeadlockTest** — reverted to main branch version (test is inherently fragile with `@Timeout(5)` for deadlock detection — adding `assertDoesNotThrow` doesn't improve it meaningfully). Note: could not create a GitHub issue as issues are disabled on this repo (uses JIRA). 5. **RouteMustHaveOutputOnExceptionTest** — now sends a message to `direct:start` and verifies `mock:result` receives it via `MockEndpoint.assertIsSatisfied()` 6. **AdviceWithTryCatchFinallyTest** — now verifies `mock:replaced` receives 1 message and `mock:replace-me` receives 0 messages after advice All tests pass locally. _Claude Code on behalf of gnodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
