apupier commented on code in PR #24856:
URL: https://github.com/apache/camel/pull/24856#discussion_r3614094358


##########
components/camel-spring-parent/camel-spring-xml/src/test/java/org/apache/camel/spring/produce/MyCoolBeanTest.java:
##########
@@ -31,8 +33,10 @@ public class MyCoolBeanTest {
     ApplicationContext applicationContext;
 
     @Test
-    public void testProducerTemplate() throws Exception {
+    public void testProducerTemplate() {
         MyCoolBean cool = applicationContext.getBean("cool", MyCoolBean.class);
+        assertNotNull(cool, "MyCoolBean should be resolved from application 
context");
+        assertNotNull(cool.producer, "ProducerTemplate should be injected via 
@Produce annotation");
         cool.sendMsg();

Review Comment:
   a real validation would to be check that the message is really called and 
sent to the route. There is a sendBody Hello World to a producer log:foo
   
   here is doesn't really check what is mentioned by the test name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to