JinyuChen97 commented on PR #8882: URL: https://github.com/apache/camel-quarkus/pull/8882#issuecomment-5021557833
> I've not done a deep review (yet), but I think you could simplify things a lot and just copy the tests as-is and add `quarkus-junit-internal` to the relevant integration-test module(s) (it may actually already be there transitively). > > The problem with reimplementing the tests as `@QuarkusTest` is that you need a bunch of extra test profiles. And that slows things down because you end up restarting the app multiple times. Thanks for the feedback, this is also my concern as well. Since each of migrated test has slightly different application properties, so they can't easily share the same profile. But I'm also wondering if we migrate them as QuarkusUnitTest, for each QuarkusUnitTest, they will start a new quarkus instance, will that also put pressure on CI maintain? I actually tried moving the QuarkusUnitTest tests directly into integration-test modules, there is an issue when running QuarkusUnitTest and QuarkusTest together caused some conflict exception in quarkus test framework, I need to modify the maven-surefire-plugin to change the execution order of QuarkusUnitTest and QuarkusTest to let QuarkusUnitTest run first, then QuarkusTest to fix this error. Thanks for any suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
