Croway opened a new pull request, #24801: URL: https://github.com/apache/camel/pull/24801
## CAMEL-24186: camel-cxf — code-quality cleanup Behaviour-preserving cleanups from an AI-assisted code review of the `camel-cxf` component family. This is the safe, mechanical **batch 1** of the improvements umbrella [CAMEL-24186](https://issues.apache.org/jira/browse/CAMEL-24186); remaining items (refactors, deprecated-API migrations that touch semantics, fail-loud changes) are tracked there as follow-ups. ### Changes - **CxfConverter** — `toDataFormat` now calls `toUpperCase(Locale.ROOT)` instead of the default-locale `toUpperCase()` (avoids the Turkish-i class of bug when resolving the data-format enum). - **CxfRsInvoker** — fix the misspelled private constant `SUSPENED` → `SUSPENDED` (internal key; no functional change). - **CxfRsProducer** — remove two discarded `sfb.getResourceClasses();` calls whose result is thrown away and immediately re-fetched on the next line. - **CxfConsumer** — remove the no-op out-fault observer wrapper (`setOutFaultObserver(m -> original.onMessage(m))`) that just re-delegated to the original observer, plus the now-unused `MessageObserver` import. - **SpringBusFactoryBean** — make `bf` a method-local variable instead of an instance field (it was only used within `getObject()`). - **CxfMessageMapper** — fix a Javadoc `{@link}` pointing at a class that does not exist in the module. ### Testing - `mvn formatter:format impsort:sort` clean; all six modules build. - Existing test suites pass for the touched modules (transport, spring-common in full; converter/producer/binding and consumer smoke tests for rest/soap). No behaviour change is intended or observed. --- _Authored by Claude Code (Claude Fable) on behalf of Federico Mariani (GitHub: @Croway)._ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
