apupier commented on code in PR #24774:
URL: https://github.com/apache/camel/pull/24774#discussion_r3594421161
##########
components/camel-lumberjack/src/test/java/org/apache/camel/component/lumberjack/LumberjackUtil.java:
##########
@@ -94,16 +95,16 @@ protected void channelRead0(ChannelHandlerContext ctx,
ByteBuf msg) {
// send 5 frame windows, without pausing
windows.stream().forEach(window ->
channel.writeAndFlush(readSample(String.format("io/window%s.bin", window))));
if (waitForResult) {
- Awaitility.await().until(() -> windows.size() ==
responses.size());
+ Awaitility.await().atMost(30, TimeUnit.SECONDS).until(() ->
windows.size() == responses.size());
Review Comment:
I'm not sure that it is useful given that when things are working the test
is taking less than 300 ms
https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=camel&search.timeZoneId=Europe%2FParis&tests.container=org.apache.camel.component.lumberjack.LumberjackComponentTest
https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=camel&search.timeZoneId=Europe%2FParis&tests.container=org.apache.camel.component.lumberjack.LumberjackDisconnectionTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
